Skip to content

Input: add support for start and end decorations#72

Closed
csillag wants to merge 5 commits intomasterfrom
csillag/input-decorations
Closed

Input: add support for start and end decorations#72
csillag wants to merge 5 commits intomasterfrom
csillag/input-decorations

Conversation

@csillag
Copy link
Copy Markdown
Contributor

@csillag csillag commented Sep 30, 2025 •
edited
Loading

(This PR is implemented on top of #100 and #101, so only the last few commits belong to this change.)

<Input
    placeholder="Search..."
    beforeStartDecoration={<SettingsIcon className="h-4 w-4 text-muted-foreground" />}
    startDecoration={<SettingsIcon className="h-4 w-4" />}
    endDecoration={<LaunchIcon className="h-4 w-4" />}
    afterEndDecoration={<LaunchIcon className="h-4 w-4 text-muted-foreground" />}
/>

Now gets us:

image

(We can adjust the exact style for the separator when we have agreement on the working of the code.)

This is required for the designs like this:

image

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 30, 2025 •
edited
Loading

Deployed to Cloudflare Pages

Latest commit: b49869fd01beeb753b7d5bc980547aab0fd2eaff
Status:✅ Deploy successful!
Preview URL: https://4910bd08.oasis-ui.pages.dev
Alias: https://pr-72.oasis-ui.pages.dev

@csillag csillag force-pushed the csillag/input-decorations branch from a549d6a to 1b0bd77 Compare September 30, 2025 19:35
@csillag csillag force-pushed the csillag/input-decorations branch from 1b0bd77 to 2530858 Compare November 3, 2025 06:24
@csillag csillag force-pushed the csillag/input-decorations branch 2 times, most recently from 99c0df7 to 806dbb0 Compare January 14, 2026 11:01
@csillag csillag marked this pull request as ready for review January 14, 2026 11:01
@csillag csillag marked this pull request as draft January 14, 2026 11:16
@csillag csillag force-pushed the csillag/input-decorations branch from 39db876 to d7341cc Compare January 14, 2026 11:19
@lubej
Copy link
Copy Markdown
Collaborator

lubej commented Jan 15, 2026

Rebase after #101

@csillag csillag force-pushed the csillag/input-decorations branch from d7341cc to d8de9aa Compare January 19, 2026 11:10
@csillag
Add support for internal and external input decorations
89b54ea 
External decorations are separated using an extra line
@csillag csillag force-pushed the csillag/input-decorations branch from d8de9aa to 89b54ea Compare January 19, 2026 11:14
@buberdds buberdds self-assigned this Jan 20, 2026
@buberdds buberdds mentioned this pull request Jan 20, 2026
Merged
@buberdds buberdds removed their assignment Jan 21, 2026
@buberdds
Copy link
Copy Markdown
Collaborator

buberdds commented Jan 21, 2026

Replaced by #102

@buberdds buberdds closed this Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@csillag @lubej @buberdds